Wiktor Niesiobędzki

Results 53 comments of Wiktor Niesiobędzki

I'm not happy too. Though: * it's easiest way to maintain compatibility with wide range of python versions * it makes easy to annotate pure C(++) functions that doesn't have...

I've managed to inline all annotations to *py files, where they do exists: https://github.com/osmcode/pyosmium/compare/master...wiktorn:typing_annotations_inline?expand=1 For all pure C++ modules I kept the *pyi files. Does it improve situation to manageable...

To follow up on this. I was able to use [mypy](https://github.com/python/mypy) to verify the completeness of the annotations but only for some definitions of completeness, i.e. only if all arguments...

I've just found python/mypy#5814. Looks promising and was merged just 2 days ago. I gave it a try on current (boost_python) version and results are better than before, but still...

Just to let you know. My current plan to move this forward is: * extend mypy stubgen so it will generate flawless pyi files for C/C++ classes generated by pybind11...

Using master branch of mypy/stubgenc it is possible now to get almost perfect stubs. The only outstanding broken annotation are in `lib/osmium.cc`: ``` def apply(reader: osmium.io.Reader, handler: osmium::handler::NodeLocationsForWays) -> None:...

Looks good to me, just a few comments: * I'm not sure if functions should be provided as multiple arguments or as one argument (tuple, list etc.). Making all (or...

You can always track progress on your own. Here is [osm_file_stats.py](https://github.com/osmcode/pyosmium/blob/master/examples/osm_file_stats.py) extended with tqdm: ```python """ Simple example that counts the number of objects in an osm file. Shows how...

NodeLocationsForWays is the reverse of what you need. Skimming through the libosmium code I found [ObjectRelations](https://github.com/osmcode/libosmium/blob/master/include/osmium/handler/object_relations.hpp) which, as far as I understand, may create the node to way index. Though...

Depends on what names you plan to find. If you're looking for street names then usually they are on way level.