Weikeng Chen

Results 288 comments of Weikeng Chen

Note that the option is not a simple bool. It may be more appropriate as a `usize`, as for the hiding bound needed for the commitments, since the prover may...

It is already a commit-and-prove SNARK wrt the witness.

It is now implemented in a separate branch: https://github.com/arkworks-rs/marlin/tree/commit-and-prove Note that this branch should not be merged, since it only supports commit-and-prove, not the general use. I guess we will...

It seems that the `from_bititerator` can be done using BigInteger's `from_bits_le`. https://github.com/AleoHQ/snarkVM/blob/cb0552a8077a3dd3fcf496bbb3447ed99401e121/utilities/src/bits.rs#L50 The implementation above looks correct. Note that we also need to implement the gadget version (ToConstraintFieldGadget) for [UInt8].

When should we merge this one (and plan for the next/next release)? And how many code changes to the other repos should we expect?

Ah, it is a little bit hard to rewrite this function in a parallel way (somehow linear). One potential temporary solution is to avoid adding many FpVars one by one,...

> > Ah, it is a little bit hard to rewrite this function in a parallel way (somehow linear). > > One potential temporary solution is to avoid adding many...

One question: For the `index` function, you mentioned "same for proving and verifying". Do you mean that they remain unchanged? Or that you will add an index to it (which...

The current implementation ([here](https://github.com/arkworks-rs/snark/blob/master/relations/src/r1cs/constraint_system.rs#L280)) does not tally indirect counts but only direct counts, which is a shortcut. What do you think?

Does it mean that we just change `self` to `&self`? My first attempt shows that this seems good: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0dcc9126df1c78347ad34fc5238617a4