Weikeng Chen

Please be sure to use Linux.

I did a pass of the code, and most are smaller points. Let me know when you want me to reach out to the repo's owner to coordinate merging this...

@daira Got it! Great points. An addition chain is a better idea. Regarding the Poseidon with alpha = 257, this is because, in Marlin or Fractal, the proving time is...

And another note from the optimized addition-subtraction chain from Daira's note: - Addition chain is very useful in computing x^{-3} x^{-5}, as in the case of Rescue, outside the constraint...

I think the part of the addition-subtraction chain would be about the interface. Should FpGadget take that into consideration, or should a separate Gadget handle this?

Updated related to the previous statement on Poseidon---if one uses a circular matrix it would no longer be the issue---a smaller alpha would often give you the smallest cost when...

And remember to add a CHANGELOG entry.

For the solution `[I; n]`, it requires a Rust feature that would be stable after Feb 11 next year. The feature is `min_const_generics`. https://github.com/rust-lang/rust/pull/79135 Should we do the second solution...

Yes. Especially because the first one, `[I; n]`, would make using Vec difficult.

There is a challenge associated with this idea. Let us say we have an unreduced emulated field element `a`, which is the result of a multiplication. After this step, the...