Weidong Xu

Results 169 comments of Weidong Xu

@joslinmicrosoft I see Tim has a change request on the PR, so I will wait a bit for him to check again. Do you have approval from Navy's team (owner...

Hi @TimLovellSmith, your change requests are either updated by service, or explained in details. Could you check again, that whether the PR is acceptable to you.

Oh, sorry I've merged it before Tim get a chance to provide more feedbacks. @joslinmicrosoft Since the target is a feature branch, if Tim give more feedback that you think...

Note that the example of the LRO uses `azure-async-operation`. Therefore, either the example is wrong, or the LRO is wrong. https://github.com/Azure/azure-rest-api-specs/blob/main/specification/codesigning/data-plane/Azure.CodeSigning/preview/2023-06-15-preview/examples/CertificateProfileOperations_Sign.json#L25C10-L25C31

Thanks @Jaxelr Header should be `operation-location`. Please make sure it matches your backend runtime. If possible, would you also give us an example of the last poll (when success)? As...

Thanks. Related doc on LRO of LongRunningResourceAction https://github.com/microsoft/api-guidelines/blob/vNext/azure/ConsiderationsForServiceDesign.md#long-running-action-operations

@archanac866 What I mean, is please double check the properties in `OverlapResource`. If any are required for user to fill in request body, make it "required".

Please wait for confirmation from author that backend ready, before merge.

Meeting notes: For search API, suggest move `maxPageSize` and `skipToken` to query parameters. Then user can POST with same body, just changing the query parameter on each request URL, when...