azure-rest-api-specs icon indicating copy to clipboard operation
azure-rest-api-specs copied to clipboard

July 2023 API Version

Open archanac866 opened this issue 2 years ago • 8 comments

Data Plane API - Pull Request

Added Fields

  • geometry(GeoJson) : added in Fields, SeasonalFields, Zones, Prescription, PlantTissueAnalyses, ApplicationData, HarvestData, PlantingData, TillageData
  • associatedResource {type(string), id(string)}: added in ApplicationData, HarvestData, PlantingData, TillageData, SensorMapping, SensorEvents, Scenes, BiomassJob, SoilMoistureJob, SensorPlacementJob

Removed Fields

  • boundaryId : field removed in SeasonalFields, Zones, Prescription, SensorMapping, SensorEvents, Scenes, BiomassJob, SoilMoistureJob, SensorPlacementJob
  • operationBoundaryId, associatedBoundaryId : field removed in ApplicationData, HarvestData, PlantingData, TillageData
  • Enum is changed so that it cannot take Boundary as resourcetype in Insights, Attachments, InsightAttachments
  • Removed attachmentLinks from response in ApplicationData, HarvestData, PlantingData, TillageData, PlantTissueAnalyses

Changes in Controller

  • Removed Boundary controller
  • Removed Weather controller
  • Removed List , ListByParty APIs in Fields, SeasonalFields, Zones, Prescription, PlantTissueAnalyses, ApplicationData, HarvestData, PlantingData, TillageData
  • Added Search API in Fields, SeasonalFields, Zones, Prescription, PlantTissueAnalyses, ApplicationData, HarvestData, PlantingData, TillageData
  • Added Overlap API in Party, to find overlapping area between two resources.

Is this review for (select one):

  • [ ] a private preview
  • [X] a public preview
  • [ ] GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/agrifood/data-plane/Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json
  • Updated paths:

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

archanac866 avatar Jul 11 '23 07:07 archanac866

Hi, @archanac866! Thank you for your pull request. To help get your PR merged:

  • Ensure you reviewed the checklists in the PR description.
  • Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.
  • For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
  • Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 110 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    agfood.json 2023-07-01-preview(8cbc09a) 2023-06-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/application-data' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L9:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/application-data' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L371:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/boundaries' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L1314:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/boundaries/cascade-delete/{jobId}' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L1544:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/boundaries' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L1668:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/boundaries/{boundaryId}' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L1912:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/boundaries/{boundaryId}/overlap' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L2106:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/fields' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L4260:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/fields' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L4528:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/harvest-data' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L4873:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/harvest-data' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L5291:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/planting-data' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L9835:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/planting-data' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L10288:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/plant-tissue-analyses' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L10664:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/plant-tissue-analyses' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L11039:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/prescriptions' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L12030:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/prescriptions' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L12415:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/seasonal-fields' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L13153:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/seasonal-fields' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L13538:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/tillage-data' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L16137:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/tillage-data' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L16576:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/weather' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L16938:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/weather/delete-data/{jobId}' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L17058:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/weather/ingest-data/{jobId}' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L17180:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/weather-data/:fetch' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L17302:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/parties/{partyId}/zones' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L17361:5
    :warning: 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/zones' removed or restructured?
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L17726:5
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'Boundary' removed or renamed?
    New: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L13722:3
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L18015:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'SearchBoundaryQuery' removed or renamed?
    New: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L13722:3
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L18015:3
    :warning: 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'WeatherDataDeleteJob' removed or renamed?
    New: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L13722:3
    Old: Microsoft.AgFoodPlatform/preview/2023-06-01-preview/agfood.json#L18015:3
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 70 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.4) new version base version
    package-2023-07-01-preview package-2023-07-01-preview(8cbc09a) default(main)

    [must fix]The following errors/warnings are introduced by current PR:

    Only 30 items are listed, please refer to log for more details.

    Rule Message Related RPC [For API reviewers]
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L10
    :warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L10
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L15
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L65
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L2986
    :warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L2986
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L3041
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L3379
    :warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L3379
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'HarvestDataModel'. Consider using the plural form of 'HarvestData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L3384
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L3434
    :warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L7531
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L7570
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L8074
    :warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L8074
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'PlantingDataModel'. Consider using the plural form of 'PlantingData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L8079
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L8129
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L8467
    :warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L8467
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L8522
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L9553
    :warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L9553
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L9608
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L10381
    :warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L10381
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L10436
    :warning: ListInOperationName Since operation response has model definition in array type, it should be of the form '_list'.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L13071
    :warning: PaginationResponse Operation might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L13071
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'TillageDataModel'. Consider using the plural form of 'TillageData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L13076
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L13126


    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L12710
    AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L12778
    AvoidAnonymousTypes Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L12850
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L90
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L95
    :warning: LroHeaders A 202 response should include an Operation-Location response header.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L125
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L133
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L160
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L165
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L189
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L214
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L219
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L226
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L250
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L273
    :warning: PatchInOperationName 'PATCH' operation 'ApplicationData_CreateOrUpdate' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L273
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L281
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L288
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L315
    :warning: OperationIdNounConflictingModelNames OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'ApplicationDataModel'. Consider using the plural form of 'ApplicationData' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L350
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L355
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L362
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L383
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L413
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L541
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L574
    :warning: PathParameterSchema Path parameter should specify a maximum length (maxLength) and characters allowed (pattern).
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L581
    :warning: ErrorResponse The error property in the error response schema should be required.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L605
    :warning: PatchInOperationName 'PATCH' operation 'Attachments_CreateOrUpdate' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L628
    :warning: PatchContentType A patch operation should consume 'application/merge-patch+json' content type.
    Location: Microsoft.AgFoodPlatform/preview/2023-07-01-preview/agfood.json#L629
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    ️️✔️Automated merging requirements met succeeded [Detail] [Expand]
    Posted by Swagger Pipeline | How to fix these errors?

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from ca162308f1010bfb85b9c85021e863e7bd397a1f. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	No package detected after generation
    Posted by Swagger Pipeline | How to fix these errors?

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.AgFoodPlatform https://apiview.dev/Assemblies/Review/109630fff7ed4974a8fa1e42dfe0c334

    Thank you for your contribution archanac866! We will review the pull request and get back to you soon.

    ghost avatar Jul 11 '23 07:07 ghost

    Thank you for your contribution archanac866! We will review the pull request and get back to you soon.

    Hi @archanac866! Your PR has some issues. Please fix the CI issues, if present, in following order: Avocado, SemanticValidation, ModelValidation, Breaking Change, LintDiff.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic ValidationFix-SemanticValidation-ErrorHigh
    Model ValidationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffHigh

    If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel.

    Hi @archanac866! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
    For more details refer to the wiki.

    @weidongxu-microsoft We have added the resourceType and resourceId as part of response so that the customer will know the area belongs to which resource and also for the future when the array size can be more than 2, then we will resturn the list of resource IDs with their corresponding areas to make it more readable.

    archanac866 avatar Jul 24 '23 05:07 archanac866

    @archanac866

    What I mean, is please double check the properties in OverlapResource. If any are required for user to fill in request body, make it "required".

    weidongxu-microsoft avatar Jul 24 '23 05:07 weidongxu-microsoft

    Please wait for confirmation from author that backend ready, before merge.

    weidongxu-microsoft avatar Jul 26 '23 01:07 weidongxu-microsoft

    @mikekistler could you please recommend what should we rename Parties_PostOverlap to?

    archanac866 avatar Aug 08 '23 15:08 archanac866

    Parties_GeoOverlap looks fine. Could have also be Parties_ComputeOverlap.

    mikekistler avatar Aug 08 '23 17:08 mikekistler