Hirotaka Tagawa / wafuwafu13 comments

Results 23 comments of


                                            Hirotaka Tagawa / wafuwafu13

[cp] Add test for cycle symlink

test passes in my local environment... :sweat:

[cp] Add test for cycle symlink

I don't know how to solve this problem in windows, so close

[cp] Add test for cycle symlink

`'cp: cannot create directory \'newsub\': No such file or directory'` 🤔

terraform-provider-aws/internal/service/datasync/task.go

I'm working on this

Some use-cases may require allowing an empty URL

I write https://github.com/axios/axios/pull/3791, but I didn't given it enough thought. I agree to revert.

docs(static_provisioning): add a note that don't proceed to the next step until pv `STATUS` is `Bound`

/remove-lifecycle stale

Make all output stable by sorting attributes

> DynamoDB does not provide any guarantee for attribute ordering. Thus, we don't want to impress that the native DynamoDB delivers a guarantee for attribute ordering. dynein doesn't deliver a...

feat(ecs-patterns): support dualstack ALB in both ec2 and fargate

Build Log ``` @aws-cdk-testing/framework-integ: Snapshot Results: @aws-cdk-testing/framework-integ: Tests: 16 failed, 807 total @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src2783938204/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.alb-ecs-service-command-entry-point.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src2783938204/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/ec2/integ.application-load-balanced-ecs-service.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src2783938204/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.alb-fargate-service-command-entry-point.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src2783938204/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.alb-fargate-service-health-check.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src2783938204/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https-idle-timeout.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src2783938204/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-ecs-patterns/test/fargate/integ.alb-fargate-service-https.js...

feat(ecs-patterns): support dualstack ALB in both ec2 and fargate

I will fix all. ex) ```zsh $ yarn integ aws-ecs-patterns/test/ec2/integ.application-load-balanced-ecs-service.js --update-on-failed --parallel-regions eu-west-1 yarn run v1.22.19 $ integ-runner --language javascript aws-ecs-patterns/test/ec2/integ.application-load-balanced-ecs-service.js --update-on-failed --parallel-regions eu-west-1 Verifying integration test snapshots... CHANGED aws-ecs-patterns/test/ec2/integ.application-load-balanced-ecs-service...

feat(ecs-patterns): support dualstack ALB in both ec2 and fargate

### ✅ aws-ecs-patterns/test/ec2/integ.application-load-balanced-ecs-service success ### ❌ -> ✅ aws-ecs-patterns/test/ec2/integ.alb-ecs-service-command-entry-point ``` AWS::ECS::Service | CREATE_IN_PROGRESS ``` ``` $ aws ecs describe-tasks --cluster aws-ecs-integ-alb-ec2-cmd-entrypoint-Ec2ClusterEE43E89D-zBVKZa6JEBrW --tasks xxxxxxxxxxxxxxx | jq '.tasks[].stopCode' "EssentialContainerExited" ``` fixed at...