Vyas Ramasubramani comments

Results 891 comments of


                                            Vyas Ramasubramani

Implement distributed sorted for ``cudf_polars``

/ok to test 06690966ee6690a16991824f31fe5ccde17d1941

Implement distributed sorted for ``cudf_polars``

Is this PR waiting on a review at this point?

[POC] GPT2Tokenizer using cudf

Closing for now. We can reopen when we have the bandwidth to work on this tokenizer again.

Cannot find libnvcomp.so.4 on ARM64

Since kvikio no longer uses nvcomp this issue is no longer applicable. It would be good to verify that cudf does not have similar issues, but I have not seen...

Inline functions that return static references must have default visibility

Can we close this (and #1651) now that #1654 is resolved?

lint: replace `isort` with Ruff's rule I

> Hi @Borda, thanks for this. However, we have been keeping isort because ruff does not support Cython code but isort does. See this discussion for more info: [#14882 (comment)](https://github.com/rapidsai/cudf/issues/14882#issuecomment-1910887340)...

lint: replace `isort` with Ruff's rule I

/ok to test

lint: replace `isort` with Ruff's rule I

You'll notice that we have isort configuration in each of our Python package's pyproject.toml files, [like cudf's here](https://github.com/rapidsai/cudf/blob/branch-24.10/python/cudf/pyproject.toml#L82). We definitely want to preserve those rules, so you'll need to add...

lint: replace `isort` with Ruff's rule I

@Borda let us know if you need any help here. Please also retarget this PR at branch-24.12, we are on the verge of freezing 24.10.

lint: replace `isort` with Ruff's rule I

Thanks for this @Borda!