Vyas Ramasubramani
Vyas Ramasubramani
Is this PR just waiting on reviews? If so, I can take a look but also it looks like we've had a couple of reviewers do some thorough passes already...
Agreed, I just wasn't sure where we were. I wouldn't want to merge additional complexity for no benefit either.
@rjzamora if we still don't have evidence that this change is a positive, should we close the PR? I've moved it to 25.12 for now.
Depends on #18770
#18770 is merged so this PR should be ready for proper review once conflicts are resolved.
If @gmarkall is happy with the PR now then we should be mostly set. We just need to verify the packaging and CI changes
I'd rather wait to test kvikio until we have kvikio wheels. Aside from that, agree with everything here.
Apologies for the delayed response on the poll, I should be able to make that time work though.
This was a VDR request, and I suspect it is what #16869 was intended to address (@singhmanas1 could confirm). If that is the case, I think that we can close...
I'm going to close this as addressed by the PRs mentioned above.