Vyas Ramasubramani

Results 904 comments of Vyas Ramasubramani

Also while doing that, we should consider pinning proj in dependencies.yaml (unless the migration is completed on cf prior to this PR merging, in which case we can remove the...

I don't think this PR is going to work until the packages are restructured as discussed in the above threads. Right now cuproj is build as part of cuspatial, so...

Sorry for the slow response here. @robertmaynard is best positioned to answer the current state of things here. The last time that we looked into this, the steps required were...

No, it is currently producing a PosixPath. But that is a good pointer, that does seem like the way that this should work. This seems similar to what I reported...

Indeed, that seems to be it. I added ``` if fullname in self.submodule_search_locations: print( f"The submodule_search_locations for {fullname} " f"are {self.submodule_search_locations[fullname]}" ) submodule_search_locations: list[str] = list(self.submodule_search_locations[fullname]) ``` and I see...

The output is the same both with and without the loader (commenting out `# loader=ScikitBuildRedirectingLoader(fullname, redir),`).

@LecrisUT any other thoughts on how we ought to proceed here? I've committed the test to the repo so hopefully it's easy enough to reproduce the issue if you need...

That sounds like a solid plan. I don't follow the difference between your second and third top-level bullets, but in general the approach of adding tests for each of the...

@henryiii friendly ping. Does the above approach of adding xfailed tests first sound OK?