Vyas Ramasubramani

Results 904 comments of Vyas Ramasubramani

There are additional changes that will be needed for CUDA 11 compatibility that I didn't bother with yet. I also haven't updated the Python recipes at all, but that should...

@msarahan I've assigned this PR to you since you were planning to take this over. Please reassign it if you expect someone else to wind up being the one to...

Sure I can test that, although I wouldn't expect that to work. That is implementing the behavior of CMake defines, not the more general case of arbitrary CMake arguments. That...

Apologies I thought I included information on this in the original issue. The problem is on [this line for parsing out the environment variable](https://github.com/scikit-build/scikit-build-core/blob/main/src/scikit_build_core/settings/sources.py#L260). The split on the semicolon does...

I think you're probably right that `CMAKE_PREFIX_PATH` and `CMAKE_MODULE_PATH` aren't good examples here though because we may not support setting them in this way without conflicting with scikit-build-core's methods of...

Before @henryiii updated #727 to use shlex (which was a great solution in that case) I was using [a regex](https://github.com/scikit-build/scikit-build-core/pull/727/commits/c18c0d4aa0d850896496781a456159de0d2fbced) to capture this. In this instance maybe that's the only...

How about something like this? ``` In [25]: import re ...: cmake_args = "-DCMAKE_PREFIX_PATH='/path/to/a;/path/to/b';-DCMAKE_MODULE_PATH='/path/to/c;/path/to/d'" ...: [x for x in re.split('''((?:[^;"']|"[^"]*"|'[^']*')+)''', cmake_args) if (stripped := x.strip()) and not re.match(";+", stripped)] Out[25]:...

I'm not sure what syntax you're suggesting to deprecate since the core syntax is CMake's and not SKBC's.

The last question on here was answered in https://github.com/scikit-build/scikit-build-core/issues/944#issuecomment-2471594487 and below.