Vyas Ramasubramani

Results 884 comments of Vyas Ramasubramani

Reopening since there is still interest in this work.

I think it's fine for an empty filter to not raise any error. As @bdice pointed out, that is the expected and documented behavior. I think the reason it is...

@cbkerr @bdice can one of you take another quick look at this?

Works for me. I'm fine not raising on nonexistent keys.

I think we still want to target this change for 2.0 if possible since docs are quite valuable for us. @atravitz do you know if there was more to be...

@atravitz could you provide an update here?

Regarding the `synced_collections` import, this was intentional. I'm happy to revisit the discussion, but the original rationale for this design is that, while `signac` happens to depend almost exclusively on...

I think I am mostly on board with the suggested structure. Some minor comments/questions: - Although I have seen `vendor`, empirically `thirdparty` or `extern` are more common in my experience....

I wouldn't mind adding a factory, although we'd probably want to put a bit more thought into the API; I would probably expect the `buffered` and `attr` to be boolean...

That's why I asked about what exactly @bdice wanted to see from a prototype. I was going to suggest exactly what @mikemhenry did, making an ASCII diagram to see what...