Vladimir Sitnikov

Results 998 comments of Vladimir Sitnikov

@whitingjr what do you mean by `the proposed contribution` ?

>Do you want the Map with PhantomReferences checked with the same key name before adding the reference ? Technically speaking, there might be multiple statement names for a single SimpleQuery....

@rhavermans , would you please rebase instead? Merge makes it hard to review in the GitHub UI.

@rhavermans , If I were you I would just rebase and force push. However you are welcome to do whatever suits you better.

@rhavermans , 1) code changes look good 2) not enough tests %-/ `java.sql.Statement#setMaxRows` + `java.sql.ResultSet#setFetchSize` combo is not tested. Could you please refactor `testFetchSizeZero`, `testFetchSizeOne` and similar to use `Parameterized`...

I wonder if #898 can help testing this change

>the code is fine the way it is, thanks for the PR. I hope nobody really uses a float for a timeout! I wonder what is the declared/documented semantics for...

Re typecache, there's https://github.com/pgjdbc/pgjdbc/pull/914 Have you seen it? It does not solve one-one issue though.

`mvn javadoc:javadoc`

1) I assume all the `WIP` PRs are WIP. Do you consider this ready for merge? Do you want to just have a review? 2) I have not reviewed this...