Vladimir Kotal
Vladimir Kotal
The Fortran lexing rules already contain file/path matching: https://github.com/oracle/opengrok/blob/0e0e613f0e7824b129796f77d024a0455d659ed9/opengrok-indexer/src/main/jflex/analysis/fortran/FortranXref.lex#L166-L184 and there is also https://github.com/oracle/opengrok/blob/0e0e613f0e7824b129796f77d024a0455d659ed9/opengrok-indexer/src/main/jflex/analysis/fortran/FortranXref.lex#L89-L96 so perhaps these need to be augmented and/or receive rule similar to the one used for...
There should be a test file that actually uses these newly supported properties. The lexer should be run on the file and compare the xref to golden stored output -...
> > There should be a test file that actually uses these newly supported properties. The lexer should be run on the file and compare the xref to golden stored...
> > fix the `onNonSymbolMatched()` arguments > > You mean this [84c1728](https://github.com/oracle/opengrok/commit/84c1728e7fd88ffa5d2df17957c54558257b9c7d) ? yep, something like this (modulo the missing white space around binary operators)
> Do you have any scripts like indent,style oe clang-format and the settings I can use ? The style check is run during Maven build of the project using the...
> > The style check is run during Maven build of the project using the `maven-checkstyle-plugin` (e.g. `mvn -DskipTests=true verify`), the rules are stored in https://github.com/oracle/opengrok/tree/master/dev/checkstyle > > Is it...
This could be related to #3360 - the NPE happened when handling `NamingException` in `lookup` on lines 405-406 so it could not get to perform the failover: ```java 404 }...
Each authorization plugin extends `AbstractLdapPlugin` which has its own instance of `LdapFacade` (constructed in `AbstractLdapPlugin#load()`) that performs the failover. This means that each plugin will have to failover individually.
The consequence is that there is no connection sharing between plugins. There are as many connections to the same LDAP server (assuming normal circumstances) as there are types of plugins...