Vladimir Kotal

Results 485 comments of Vladimir Kotal

The solution I have in mind is to move most logic/data from the `LdapFacade` to new `LdapPool` class, e.g. it would hold a list of servers, timeouts, webhooks, search controls,...

> Or a new plugin LdapServerPlugin, marked as requisite and populating a request attribute with LdapFacade which initializes just once. This wouldn't require a change in the core. Interesting idea...

Another alternative class to use for reference counting might be the abstract [`ReferenceManager`](https://lucene.apache.org/core/9_3_0/core/org/apache/lucene/search/ReferenceManager.html) from Lucene.

I got hit by this too and was baffled because I saw that `JvmMemoryMetrics` in Micrometer produces tagged metrics like: ``` jvm_memory_used_bytes{area="nonheap",id="CodeHeap 'profiled nmethods'",} 1.8733824E7 jvm_memory_used_bytes{area="heap",id="G1 Survivor Space",} 2.9360128E7 jvm_memory_used_bytes{area="heap",id="G1...

I see, it just shares the same symptom. Dne pá 18. 9. 2020 7:46 uživatel dnowak-wrldrmt napsal: > @vladak This is not a solution for the > problem as the...

Indeed, it seems that the current behavior of various HTTP clients, including browsers, is [not to send the fragment identifier](https://stackoverflow.com/questions/5738627/was-there-ever-a-proposal-to-include-the-url-fragment-into-the-http-request/6158509#6158509) in the HTTP request. This means there is no way...

There is no way how to fix this problem for pre-existing links as far as I know due to the reason described above. For new links, the changes need to...

For the approach with links changed during indexing, I believe most of the links are generated via the methods defined in https://github.com/oracle/opengrok/blob/master/opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/JFlexXrefUtils.java, for example https://github.com/oracle/opengrok/blob/e34493b3497cb7f156be6e033842cdfac9427cb5/opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/JFlexXrefUtils.java#L311-L315 Anyhow, if changed there, this...

Similarly for functions in `utils/mirror.py` - things like reporting ignored repositories.

If history cache is disabled (for given project), it is a question whether to override the short circuit in `HistoryGuru#getHistoryFromRepository()` for repositories that support per directory history. To expand on...