Vishal Kakadiya

Results 11 comments of Vishal Kakadiya
trafficstars

Hi @guilhem 👋 Thank you for taking the time to open this PR. 🙇 Could you share more details about the use case behind defining all the options as constants?

Only white space changes, I'm closing this PR at the moment. Thanks!

@moraleida Hi 👋, you guys are doing awesome work with Engineering Practices! 🙌 Thank you for making these awesome docs. I was recently checking this issue and would like to...

@Antonio-Laguna Thank you for quickly checking on this. 🙌 Yes, it totally makes sense to build this as the props, let me know if you want me to update this...

@felixarntz I have updated AC for this epic. It is ready for review now. Thanks!

@felixarntz @joemcgill @jjgrainger I have raised PR for this task [here](https://github.com/10up/plugin-check/pull/94). Thanks!

I have updated the PR status from open to draft so we don't merge it accidentally. 🙂

I'm assigning this to @jjgrainger, so he can continue on this once we unblock. Thanks!

@jjgrainger I will update AC for this issue, thanks! 🙂

@felixarntz I have updated AC for this epic, and it is ready for review now. Thanks! 🙂