Robert van Gent

Results 114 comments of Robert van Gent
trafficstars

@caarlos0 Can you verify which version of ie-proxy you ended up using? Our test suite does build on Darwin, and when I tried downgrading to the 0.0.2 version, it reproduced...

Carlos can you try the suggestion in https://github.com/mattn/go-ieproxy/issues/34#issuecomment-1094135564? On Fri, Apr 8, 2022, 5:20 PM Carlos Alexandro Becker < ***@***.***> wrote: > i was using v0.0.3, downgraded to v0.0.1, which...

If I am reading the bugs correctly, this works fine when you're actually compiling on Darwin; it fails when you are cross-compiling. Is that correct? `go mod graph` shows Go...

I also filed https://github.com/Azure/azure-pipeline-go/issues/31 with azure-pipeline-go.

@bep `v0.24.0` should be OK if you want to try it.

Sorry, I'm not super familiar with OpenCensus or OpenTelemetry. Is this a backwards-compatible change?

I don't see how it's possible to make this change if it's not backwards compatible. Wouldn't it potentially break all existing users?

(Doesn't OpenTelemetry have a compatibility story with OpenCensus?)

The minimum Go version is not a problem. I think https://opentelemetry.io/docs/migration/opentracing/ describes how to make it backward compatible, by having the OpenTelemetry code also emit OpenCensus events.

If I understand correctly, `gcsblob.OpenBucket` handles this already, because it takes a `gcp.HTTPClient`. So does the `URLOpener`, since it also has a `gcp.HTTPClient` field. So this is just about the...