Robert van Gent

I don't think anything has changed since my last comment; per-object ACLs are not uniformly supported across the Cloud providers and so not supported by `gocloud`.

Please don't forget about the "This bug also means that it is not possible to use an Uploader to upload large objects to buckets with default object lock" aspect of...

What problem are you seeing today that you're trying to solve? I.e., why do you want to set `MinBatchSize` to something greater than 1 if your throughput is low?

Interesting, thanks for the description. What do you hope to improve by increasing the `MinBatchSize` above 1? Context: This proposal would add a fair amount of complexity to an already-quite-complicated...

Please go ahead and force-push and I'll re-review.

No concrete plans, no. Happy to take pull requests. What does a sample `sql.OpenDB` look like?

Happy to take a PR on this. I think you should be able to start with https://github.com/google/go-cloud/blob/master/postgres/gcppostgres/gcppostgres.go and modify it for the above.

It seems OK to me. I don't think these parameters are supported in the aws.Config (correct me if I'm wrong through), so rather than modifying `V2ConfigFromURLParams` (https://github.com/google/go-cloud/blob/master/aws/aws.go#L181), you'll need to...

The tests are failing with a data race: WARNING: DATA RACE Write at 0x00c00044e3f0 by goroutine 978: gocloud.dev/pubsub/batcher.(*Batcher).callHandler() /home/runner/work/go-cloud/go-cloud/pubsub/batcher/batcher.go:287 +0x1ca gocloud.dev/pubsub/batcher.(*Batcher).handleBatch.func1() /home/runner/work/go-cloud/go-cloud/pubsub/batcher/batcher.go:217 +0x54 Previous read at 0x00c00044e3f0 by goroutine 979:...

I think the flushing PR looks close to good, I am holding off on reviewing this one until the open questions there are addressed and it is submitted.