unicorn icon indicating copy to clipboard operation
unicorn copied to clipboard

Published 20 hours ago • verified publisher icon unicorn-gallery

Dockerize unicorn!

Open mre opened this issue 7 years ago • 3 comments

Being able to run the project in a container would be nice.

Todo:

  • [X] Create a Dockfile.
  • [ ] Add instructions on how to build the image.
  • [ ] Push the image to Dockerhub.

mre avatar Oct 05 '18 10:10 mre

Actually there are already two PRs open for this. #11 and #12. We should probably merge the best parts of those into one.

mre avatar Oct 22 '18 14:10 mre

@mre Is there an issues that blocks us from merging one of PRs?

Leprechaunz avatar Oct 26 '18 10:10 Leprechaunz

Ah, not really. I'm just undecided which one to merge. Both look quite nice, so probably the best of both. I haven't tested https://github.com/mre/unicorn/pull/12 yet, that's why I didn't go forward yet. Could you? If you're happy with what you see (thumbnails working, routes as expected, documentation, etc), could you merge his changes into your PR and then we go from there? I think that's a good compromise.

mre avatar Oct 26 '18 10:10 mre