Thomas
Thomas
` 170.4 registry/storage/driver/s3-aws/s3.go:315:99: cannot use maxChunkSize (untyped int constant 5368709120) as int value in argument to getParameterAsInteger (overflows)`, hm, fine, int64 it is I suppose
Is it worth keeping the max chunk size around, or is it worth reducing it? 5 gigabytes is huge, and I don't envision any production system should be using that...
I guess the other question is why is it building with int32 in GitHub actions? Should it be?
`(*bytes.Buffer).Next` takes an int, so I'm not really sure what to do here - an int64 simply won't fit. https://github.com/distribution/distribution/blob/6eb428a20ed0d70001adabab49936889fdf6db6f/registry/storage/driver/s3-aws/s3.go#L1573 Is there a hard requirement for supporting 32 bit architectures?...
@milosgajdos Is there anything I can do to help you with the review?
No worries, thanks! Appreciate you taking the time to review it. I wasn't meaning to rush you, I genuinely was keen to understand if there was anything I could do...
Hope your tests went okay. If it's helpful, there is a prebuilt image here https://github.com/users/uhthomas/packages/container/package/distribution%2Fregistry
Thank you @milosgajdos, @Jamstah and everyone else who took the time to review and test. Really happy to see this finally get over the line!
Why not simply use [filepath.WalkDir](https://pkg.go.dev/path/filepath#WalkDir) instead? Doesn't need a new dependency and achieves the same goal of being more efficient by not calling `os.Lstat` for each file or directory.