Thomas
Thomas
That was fixed though? https://github.com/dotdc/grafana-dashboards-kubernetes/releases/tag/v2.7.3
@dotdc I don't think this is what was intended? The original change wanted to match a literal '.', not just everything. My understanding is that the latest version to fix...
Yeah I have no doubt it'll work for the general case, but the feature added for node names with dots in won't work anymore.
Only concern I have is the use of `key` vs `path` (`key := d.s3Path(path)`). I can't see much consistency, though I imagine `key` is almost always correct to use.
Thanks for running the tests! As suspected, there was some stuff which had to be changed regarding `key` versus `path`. I've fixed that and have verified the failing test now...
Okay, I tried using `key` everywhere to avoid calling `d.s3Path` a bunch, but there are some edge cases and I'm not keen to change existing behavior. Should be good now.
> @uhthomas can you also please stop squashing while the PR is being reviewed? It's hard to track changes that way. We'll squash it before the MR is merged. Sorry...
Thank you again for your time :) I appreciate you reviewing this.
Neither #6839 or #6576 as I am using the gateway API and not ingresses. I am issuing way too many certs to LE atm. Is there any way to work...
So, upon reading the [PromethuesSpec](https://prometheus-operator.dev/docs/operator/api/#prometheusspec), specifically the `containers` attribute, it looks like some of this can be resolved. This took a lot of digging, and doesn't quite solve the original...