Taylor Smock

Results 112 comments of Taylor Smock

> user information isn't available at all, making it impossible to show a user only their images, Yep. I ran into that problem. I did get user login working again,...

About the only way to get node information right now is to have an atlas file that did *not* drop unnecessary nodes -- this includes nodes that have no tags...

> But, as far as I can remember, you can't build JARs that's compatible with earlier versions of Java while also including the module information, at least not without "cheating"...

> Also what is the point of the first commit if the second one reverts it? If you want to offer two alternatives then open two PRs don't lump them...

Right now, `GET /user/preferences/key` will (according to the [wiki documentation](https://wiki.openstreetmap.org/wiki/API_v0.6#Preferences_of_the_logged-in_user)) "[return] a string with that preference's value." Which makes sense. So a `k="foo" v="{\"json\": true}"` would return `{"json": true}`, regardless...

> It seems reasonable (and good for consistency) that asking for a single preference should return a object, not just one of the attributes of the preference. The same thought...

OK. The `GET /user/preferences/key` endpoint can now return XML/JSON responses, _if and only if_ the consumer indicates that they will take the XML/JSON response in the `Accept` request header, otherwise...

Supporting `#` is easy -- the consumer just has to URL encode the key and then we have to URL decode. This is (effectively) what my patch currently does (it...

> Can the dots in the key be url encoded? E.g. /user/preference/foo%2Ebar.xml for the key foo.bar? Technically, yes. `%2E` is `.`. See [RFC3986](https://www.ietf.org/rfc/rfc3986.txt) section 2.1 for details (_all_ ASCII characters...

Honestly, I need to figure out why our code doesn't like multiple `.`s. I wrote a quick [fake site](https://github.com/openstreetmap/openstreetmap-website/files/10034387/multiple_dot_url.zip) to check and see if it was an upstream bug, and...