Taylor Smock

Results 112 comments of Taylor Smock

So I think I found a fix for the multiple `.` problem in the preference key. I _still_ don't know why the `resources :user_preferences [...]` would cause issues with `.`.

The problem is that `user/preferences/gps.trace.visibility` will lead to a routing error (it cannot find the route) if `resources` is used. I'm intending to do some debugging to figure out why...

> But I still don't understand what you are trying to achieve! I thought we'd clarified that we can't use any unescaped . characters from the keys in the urls,...

To add on to what stoecker said, once you open a ticket on https://josm.openstreetmap.de, add a link from that ticket to this PR and add `[PATCH]` to the ticket title...

I'm _pretty_ certain that mapillary_tools is architecture agnostic. I've run it on a Raspberry Pi in the past.

> Would it make sense to deprecate the old methods? Also needs review from @tomakehurst , because it's likely to collide with the extension API I didn't deprecate the old...

I'll jump in here, since I encountered the same problem in #5642. It helped that the dependency updates actually gave me actionable information, instead of just `%s`. ```diff - tzlocal.utils.ZoneInfoNotFoundError:...

My first response is "LGTM". I spent quite a bit of time tracking down errors when the stack traces weren't being printed, and it looks like #5899 will help fix...

1. It should, assuming that PKCE is used. Technically, I don't think you _need_ to use PKCE with OAuth 2.0, but you _should_. It is _highly_ likely to be a...