Elias Skogevall

Results 23 comments of Elias Skogevall
trafficstars

I have not much experience with rust, but I am happy to contribute with what I can do.

I want to have `/* eslint-disable */` in my banner.

Yes, using the core and no other libraries.

Thank you for you pull request! I have some suggested changes. Also, please squash your commits for better history.

The projected used Acorn before. I switched to Meriyah because of the performance difference and the support for ES2020. We didn't log the syntax error location before. We logged the...

Jag föredrar engelska så att andra kan läsa mina kommentarer 😁 ---- I'm making a pull request adding the property `end` to `ParserError`.

Should `'[' + loc.start.line + ':' + loc.start.column + ']: '` be removed from the message. I'm finding this quite unseccesary. It should be added by the client.

Which properties in `ParserState` should I use?

> I don't think it's an standard on this. All Parsers report this differently. Try to look what others do with AST explorer Acorn uses SyntaxError which doesn't report the...

Because the variable node is not defined in every function in `parser.ts`, I need to define the variable node at 194 places in the code. I added the parameters `context`...