Trivikram Kamat

Results 343 comments of Trivikram Kamat
trafficstars

This change should be made before 1.0.0 as per https://github.com/nodejs/corepack/issues/687#issuecomment-2746371851

AWS SDK for JavaScript v2 will enter maintenance mode on September 8, 2024 and reach end-of-support on September 8, 2025. For more information, check blog post at https://a.co/cUPnyil

I quickly looked at AWS SDK for JavaScript v3 imports in nocodb: * The `@aws-sdk/client-kafka` * added in https://github.com/nocodb/nocodb/pull/6222 * doesn't seem to be used. * The `@aws-sdk/client-s3` and `@aws-sdk/s3-request-presigner`...

The `AWS.NodeHttpClient` is not documented in v2. Maybe we should just add comment during transformation about referring to NodeHttpHandler?

Example https://github.com/awslabs/aws-solutions-constructs/blob/38de866b82507a8c8a4545b2a89f77942f5bdb5d/source/patterns/%40aws-solutions-constructs/aws-dynamodbstreams-lambda-elasticsearch-kibana/test/lambda/index.js#L17

Biome import sorting works for me on following the settings mentioned in https://github.com/biomejs/biome-zed Example repo with settings https://github.com/aws/aws-sdk-js-codemod/blob/ac758504da4ccdf2502ead248748e7af8d6053ea/.zed/settings.json#L2-L6

I'm not sure why the tests are failing. The `yarn synth` works locally for `typescript/api-gateway-parallel-step-functions` Feel free to take over the PR, or close it. The original goal for upgrading...

Can I get access to "Cloud Run Invoker" role? I would really like to test my investigation in https://github.com/nodejs/build/issues/3771#issuecomment-2192805393, by sending a request using curl and waiting up to 20...

This is happening with file uploads, since requestBody is a [File](https://developer.mozilla.org/en-US/docs/Web/API/File) object in flexible checksums middleware. https://github.com/aws/aws-sdk-js-v3/blob/9f9fe77b9f8e24ce2cad7e42ca58e2466bc969b2/packages/middleware-flexible-checksums/src/flexibleChecksumsMiddleware.ts#L122 The implementation expects it to be [ReadableStream](https://developer.mozilla.org/en-US/docs/Web/API/ReadableStream). https://github.com/smithy-lang/smithy-typescript/blob/fbe3c04b5627a8aea693b5bfc1598adbac0213d5/packages/util-stream/src/getAwsChunkedEncodingStream.browser.ts#L22

As @aBurmeseDev mentioned, the simplest workaround at the time of comment is to disable checksum computation by setting the following configuration during client creation ```js const client = new S3({...