aws-cdk-examples icon indicating copy to clipboard operation
aws-cdk-examples copied to clipboard

chore: update Lambda Node.js to 20.x

Open trivikr opened this issue 1 year ago • 2 comments
trafficstars

Noticed in: https://github.com/aws-samples/aws-cdk-examples/issues/961

Node.js 20.x is the latest version of Lambda https://aws.amazon.com/blogs/compute/node-js-20-x-runtime-now-available-in-aws-lambda/


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

trivikr avatar May 30 '24 02:05 trivikr

The tests failed make sure that you can run yarn run test or npm run --if-present test and that cdk synth works.

kaiz-io avatar May 30 '24 13:05 kaiz-io

I'm not sure why the tests are failing. The yarn synth works locally for typescript/api-gateway-parallel-step-functions

Feel free to take over the PR, or close it. The original goal for upgrading to Lambda Node.js 18.x is achieved, and this PR was just an additional update.

trivikr avatar May 30 '24 15:05 trivikr

So just fixed an issue that might have been affecting one error that you were getting. Currently the build is failing because in the project typescript/api-gateway-lambda-token-authorizer/ the test that is configured is failing because the snapshot is different.

Here is the command to run in the director to replicate the issue. npm run --if-present test

kaiz-io avatar Sep 17 '24 20:09 kaiz-io

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

github-actions[bot] avatar Sep 20 '24 06:09 github-actions[bot]