Tomasz Pluskiewicz

Results 301 comments of Tomasz Pluskiewicz

Thanks @sidharthramesh Good grief, that should be the default!

I'm trying to migrate a large jest test suite to mocha. Any chance for inline snapshots?

Here's my rendition of inline snapshots, which I added to my project using [patch-package](https://npm.im/patch-package) as `mocha-chai-jest-snapshot+1.1.4.patch` ```diff diff --git a/node_modules/mocha-chai-jest-snapshot/dist/index.d.ts b/node_modules/mocha-chai-jest-snapshot/dist/index.d.ts index da2efa6..463cb78 100644 --- a/node_modules/mocha-chai-jest-snapshot/dist/index.d.ts +++ b/node_modules/mocha-chai-jest-snapshot/dist/index.d.ts @@ -16,6...

I found one gotcha when trying to update inline snapshots in TS project. Might need to patch `jest-snapshot` (`jest-snapshot+28.1.3.patch`) ```diff diff --git a/node_modules/jest-snapshot/build/State.js b/node_modules/jest-snapshot/build/State.js index 1ee5df3..68ee45f 100644 --- a/node_modules/jest-snapshot/build/State.js +++...

This is too hackish so far. Maybe in plain JS updating inline snapshots would work. My problems appear to be with parsing TypeScript. First it complained about a decorators, which...

Hey, I just noticed that the latest version has outputs and I tried to use them for the status check. For some reason that did not work Does this look...

Oh, `env. NETLIFY_PREVIEW_URL` works. Is that right. Has the use of outputs changed with the change of how they are set in upstream steps?

What I did was to complete recreate that site on netlify and changed the site id. It deployed successfully then. Will try your suggestions if I encounter this again

Oh, the UI is using an old version? That's a red herring apparently We are still having issues with the JS lib, but as it turns out, only when passing...