Thomas Wolf

Andrey _did_ change line 48 (the `@Override`) on 2015-04-07 in commit [e54214e7](https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/bundles/org.eclipse.core.commands/src/org/eclipse/core/commands/AbstractHandler.java?id=e54214e7e8d0eaab91d8f1a529686922a51f82b5). Could it be that the git mining uses the text before the insertion?

Angelo, I don't have the time to fix this; I think you'll need to refactor quite a bit. Some points: * The DefaultLineDiffer created in [RevisionInformationSupport](https://github.com/angelozerr/jdt-codemining/blob/abcb68e1/org.eclipse.jdt.codemining/src/org/eclipse/jface/text/revisions/provisional/RevisionInformationSupport.java#L66) is not connected to...

> I have added a canApply method ... (do you prefere that?) I was thinking more along the lines of using an extension point (comment at [EGitCodeMiningStartup](https://github.com/angelozerr/jdt-codemining/blob/b833d7f/org.eclipse.egit.codemining/src/org/eclipse/egit/codemining/internal/EGitCodeMiningStartup.java#L12)), which should have...

Angelo: this doesn't work right yet. Following scenario: 1. Start Eclipse Photon. No open editors. 2. Make sure revision code minings are disabled in preferences. 3. Open a Java file....

Would make sense. Would have to be implemented apparently in RevisionAuthorsCodeMining.java and in RevisionRecentChangeCodeMining.java. A user is probably most interested in knowing who touched the code last, and when.

Yes, like plain Java HTTP, Apache MINA sshd only uses the first IP address. In part this is hard-coded in Java's `InetSocketAddress(String hostname, int port)`, which resolves the host name...

Yes, this could be turned into a parameter. RFC 4253 is irrelevant here; this is about the maximum length of an SFTP message, not about SSH packet size. The limit...

> Illogical sftp packet length: 499335 I guess openSSH sftp would run into the same problem then. This is simply a hole in the SFTP draft RFCs. They do specify...

> There are a 7 usage of this constant in the SFTP module, I don't think any of those is valid. Agreed. * [SftpModuleProperties.WRITE_CHUNK_SIZE](https://github.com/apache/mina-sshd/blob/801edabdb7723e9f5bf03fd66c6e48a2d240bb9f/sshd-sftp/src/main/java/org/apache/sshd/sftp/SftpModuleProperties.java#L103): unclear why the default subtracts 8....

Compare also https://stackoverflow.com/questions/14073554 : that is exactly the same problem, but _without Apache MINA sshd_ in the loop. That example just uses `group.shutdownNow()` to close the acceptor and the group....