Thomas Wolf

Results 146 comments of Thomas Wolf
trafficstars

As far as I see what happens is that the asynchronous connection attempt succeeds after the timeout. I'd move the timeout flag and the `isTimeout()` method to `DefaultSshFuture`. I also...

> Can we write a test for this? I've created issue [SSHD-1295](https://issues.apache.org/jira/browse/SSHD-1295) in our bug tracker for this, and have posted a test case there. Please incorporate that test into...

Looks good now. Is it OK for you if I squash this series and fix some of the javadoc comments, and then force-push onto this branch?

@lgoldstein and @gnodet: I'd appreciate your opinions on this. Please also see my thoughts at [SSHD-1295](https://issues.apache.org/jira/browse/SSHD-1295?focusedCommentId=17602860&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17602860).

"2.9.2-SNAPSHOT" is just the current development version. I don't think we'll do another patch release for this. So most likely the change will come whenever 2.10.0 is released, which may...

Just a heads up: the basic idea is going in the right direction, but cancelling a `ConnectFuture` has the same problem. I've come to the conclusion that cancellation has to...

> keep the existing verify without the flag and delegate it to call the new verify using some default that you deem relevant Yes, that was my thought exactly. The...

@elecharny could you please take look and merge this if you think it's OK? And then merge or cherry-pick it to the 2.1.X and 2.2.X branches? I'm a bit confused...

Why Java 7?? The pom sets `maven.source.version` and `maven.target.version`to 8, and when I imported mina-core into Eclipse, the projects got of course set up with Java 8. And that's on...

Missed that. And anyway `maven.source.version`"8" is likely wrong, shouldn't that be "1.8" if at all? Now I wonder why I got a Java 8 setup in Eclipse... BTW, I just...