Viktor Vilhelm Sonesten comments

Results 162 comments of


                                            Viktor Vilhelm Sonesten

Differentiate comparator 0 as the only one capable of cycle compare

I'll go over it tomorrow.

Differentiate comparator 0 as the only one capable of cycle compare

> Let me know if there was a good reason At the time I thought it was relics from an older implementation which I refactored just to remove the `unsafe`...

Differentiate comparator 0 as the only one capable of cycle compare

I want to try this out on hardware before I sign off on it. Hopefully I'll have it done by next week.

Differentiate comparator 0 as the only one capable of cycle compare

I've been testing this PR with a in `cortex-m-rtic-trace` branch, based on an `rtic-scope-dw0` branch of cortex-m that contains this PR, for use with `cargo-rtic-scope`. Without the patch I see...

DWT: address comparison configuration does not verify written mask

Related to #382.

Consider v0.8-alpha release

Preferably https://github.com/rust-embedded/cortex-m/pull/366 (trivial), too.

Consider v0.8-alpha release

#383 should be finalized, too.

Verify peripheral configuration support inline instead of seperate `has_` functions?

An edge-case to consider are RAZ/WI (Read-as-zero, writes ignored) register fields which do not necessarily have an associated flag bit to check for support. Per the standard one should try...

Verify peripheral configuration support inline instead of seperate `has_` functions?

CC @TDHolmes because of your recent work on `DWT::configure`.

Verify peripheral configuration support inline instead of seperate `has_` functions?

See above PR. Implementing an `ITM::configure_unchecked` would in this case lead to a lot of code duplication due to the lack of feature support flags.