Tommi Mäklin comments

Results 15 comments of


                                            Tommi Mäklin

Support for no exceptions?

Hi! I generally prefer C++ code that implements exception handling but I'm open to supporting turning them off. I'll have a look at what changes this would require.

Add checks that outputs are writable & inputs exist if outputting to or reading from a directory

Hi, think I originally added it just to be sure that it doesn't break anything, I have no strong feelings about supporting or not supporting windows here :grin: C++17 has...

Allow retrieving the decompressed size

For zlib, libbz2, and liblzma calculating the uncompressed size isn't typically (as far as I know) possible without decompressing the file hence the decision not to support reading from end....

Update compression_types.hpp to always detect the types

Thanks! I'll check and merge this soon.

Update compression_types.hpp to always detect the types

Hi @andriish sorry it's been a bit hectic and I forgot about this. Thanks for the reminder and the pull request; everything looks good and I'll merge now.

Would be nice to put `strict_stream` namespace inside the `bxz` namespace.

no worries, I'll add this to the next version

GGCAT keeps panicking about too many open files

This seems like it may have been fixed in https://github.com/algbio/ggcat/commit/ec68afe7dcb9897d50846e1f06b623114cead931? I'm not getting the error in a similar use case anymore after updating.

Coloring options for an input file list

hi, no I haven't unfortunately.

`Error: stold exiting` if input file(s) are compressed with unsupported compression type

Fixed in [telescope v0.6.1](https://github.com/tmaklin/telescope/releases/tag/v0.6.1); will close when updated in mGEMS.

WARNING: No newline at ending of file 'nonewline.fasta' behavior

I've encountered this in Themisto and Fulgor, which both call ggcat via the C++ API to build the unitigs for further processing. In Themisto, the warning results in a broken...