Timothy J. Raymond

Results 44 comments of Timothy J. Raymond

I'm going to reopen this since we should probably be adding those capabilities to the manifests if they're not getting added. Otherwise, we should document that there are additional steps...

Adding this checklist so we can break down the packages we need to re-enable: ## From `pkg/hubble/hubble.go`: - [ ] `github.com/cilium/cilium/pkg/hubble/monitor` (@timraymond) - [x] `github.com/cilium/cilium/pkg/hubble/peer` (@timraymond) - [x] `github.com/cilium/cilium/pkg/hubble/peer/serviceoption` (@timraymond)...

WIP on the branch [`traymond/hubble-windows`](https://github.com/microsoft/retina/tree/traymond/hubble-windows)

@shankarseal If you look at the two commits on the above-linked branch, I've selectively vendored the offending packages to an `internal` package. It's only parts of those packages that refer...

Possibly related to #85 as well

@anubhabMajumdar Looks like stalebot killed this, but I see you manually closed this as well. What was the reason here?

@BeegiiK Please fill out the full description for the issue

TIL about `//go:build ignore`, thanks for the contribution 😄 This looks pretty good to me as-is... I was able to build this with `make retina-binary` without any additional ENVs (we...

@rbtr It's because we set `CGO_ENABLED=0` here: https://github.com/microsoft/retina/blob/cf23ecb9a5ed25c787d1f6ec819518749dfb7774/controller/Dockerfile.controller#L30 . The go toolchain skips over its distaste for C here when CGO is disabled: https://github.com/golang/go/blob/e7bdc8819a19f06321d300719224abb2d8567b4a/src/cmd/go/internal/load/pkg.go#L2060-L2063