retina icon indicating copy to clipboard operation
retina copied to clipboard

Run Hubble on Windows node

Open anubhabMajumdar opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe.

Run Hubble on Windows node.

anubhabMajumdar avatar Jun 13 '24 22:06 anubhabMajumdar

Adding this checklist so we can break down the packages we need to re-enable:

From pkg/hubble/hubble.go:

  • [ ] github.com/cilium/cilium/pkg/hubble/monitor (@timraymond)
  • [x] github.com/cilium/cilium/pkg/hubble/peer (@timraymond)
  • [x] github.com/cilium/cilium/pkg/hubble/peer/serviceoption (@timraymond)
  • [x] github.com/cilium/cilium/pkg/hubble/server (@timraymond)
  • [x] github.com/cilium/cilium/pkg/hubble/server/serveroption (@timraymond)
  • [ ] github.com/cilium/cilium/pkg/monitor/agent (@timraymond)

From cmd/hubble/daemon_main.go

  • [ ] github.com/cilium/cilium/pkg/k8s/watchers
  • [ ] github.com/cilium/cilium/pkg/monitor/agent (@timraymond)

From cmd/hubble/daemon.go

  • [ ] github.com/microsoft/retina/pkg/k8s
  • [ ] github.com/cilium/cilium/pkg/k8s
  • [ ] github.com/cilium/cilium/pkg/monitor/agent (@timraymond)

From cmd/hubble/cells.go

  • [ ] github.com/microsoft/retina/pkg/k8s
  • [ ] github.com/microsoft/retina/pkg/monitoragent (@timraymond)

timraymond avatar Jul 09 '24 19:07 timraymond

WIP on the branch traymond/hubble-windows

timraymond avatar Jul 11 '24 15:07 timraymond

Hi @timraymond dont you need to port all the packages referred to in https://github.com/microsoft/retina/blob/main/pkg/hubble/hubble_linux.go? Particularly isnt "github.com/cilium/cilium/pkg/hubble/metrics" to support metrics?

shankarseal avatar Oct 29 '24 21:10 shankarseal

@shankarseal If you look at the two commits on the above-linked branch, I've selectively vendored the offending packages to an internal package. It's only parts of those packages that refer to golang.org/x/sys/unix--parts that we don't use. In the internal package, we can remove those unused parts so that the package compiles cleanly.

timraymond avatar Oct 30 '24 15:10 timraymond