Scott Lahteine

Results 422 comments of Scott Lahteine
trafficstars

If this is resolved for you with 2.1.3-b1 then we can close this. Otherwise we'll need to keep looking. AFAIK the only issues with homing are that it's tricky to...

All of these things together should help me to add LPC support to the NeoPixel cpp file: [x] Having the LPC datasheet [x] Having the linked code and Adafruit NeoPixel...

Some of these things defined as `hal_timer_t` should probably be changed to `uint32_t`. Both AVR and HC32 use 16-bit timer width, so it's very likely to overflow. If we're curious,...

> I did a pass over everything… Thanks for the review. If more variables, methods, and parameters should be working with `uint32_t` (especially under known circumstances) we can certainly apply...

Peek at #9935 for an interesting approach. It's probably not applicable here, but it's worth a look as a control model.

> Marlin communitiy needs to define what type of closed-loop solution they want to support Usually we wait for a reasonably-priced product to appear on the market, and then we...

This would be a good opportunity to make some tweaks to clarify the difference between `SOFTWARE_SPI` and `FORCE_SOFT_SPI`, as sometimes a pins file will define one or the other, and...

I see… Since `F_CPU` is not the "master value" but there is a common clock value on which the others are based, we should define that at least, and then...

I pushed a commit with what makes sense to me, but of course please apply corrections and clarifications. It's interesting that HC32 clock frequency is so configurable, and it will...

Thanks for the feedback, looking forward to your update!