Scott Lahteine
Scott Lahteine
It is not possible to review all these changes and accept them all in one PR. You should cherry-pick parts of this large PR into smaller pieces with changes limited...
Sorry this has been hanging out so long. Everything here still stable with no interim changes stepping on anything?
A lot of other stuff has been distracting, but this is still slated for merge before the release. I'm just going to merge in the latest code now, clean it...
Note that messages starting with "Error:" may cause hosts like OctoPrint to halt and disconnect. If that is not desired behavior, messages should not start with "Error:". We now have...
I get the feeling we're arriving at the station. In ten, nine, eight, …
If you do want to preserve a regex for the old pattern and also recognize the new pattern, I'm happy to help. I'm one of those mad nerds who enjoys...
I believe we've sorted out the remaining questions about the protocol changes in this PR. If there are no other concerns I'll go ahead and merge this today.
> I propose we go back to the format Will there be future updates to OpenPnP to allow for a different protocol format and additional features? If so, we should...
> in #26719 you swapped the BNT buttons in the ReARM board for the `CR10_STOCK_DISPLAY` > can ask why? To eliminate this pointless requirement only mentioned in the pins file:...
The cause is in `determine_path` which insists on a document view. ```py if not self.window.views(): view = self.window.new_file() else: view = self.window.active_view() auto = get_setting(view, 'jekyll_auto_find_paths', False) ``` Replacing with...