David E. Wheeler

Results 483 comments of David E. Wheeler
trafficstars

Could you have multiple versions of Perl installed, with Sqitch built against one and MySQL::Config built against another? To see, what's the output of these two commands? ``` sh head...

Sure looks like the same Perl. How did you install MySQL::Config?

Weird. Presumably this prints something: ``` sh /usr/bin/perl -MMySQL::Config -E 'say MySQL::Config->VERSION' ``` The [docs](https://sqitch.org/docs/manual/sqitch-authentication/) say: > For MySQL, if the [MySQL::Config](https://metacpan.org/pod/MySQL%3A%3AConfig) module is installed, usernames and passwords can be...

No, it's because I had a syntax error in the patch; Line 59 needs another `}` at the end. Here's a fixed patch: ```patch --- a/lib/App/Sqitch/Engine/mysql.pm +++ b/lib/App/Sqitch/Engine/mysql.pm @@ -56,8...

Ah-ha, very revealing. Looks like [MySQL::Config](https://metacpan.org/pod/MySQL::Config) doesn't support quoted values. Looks like its last release was in 2008, so not totally surprising. Can you do without the quoting?

That's the place to start, I guess, though the one ticket here has been open and unanswered for close to 8 years :-( This might require someone starting over.

Another false positive with `min`: ``` go func main() { if len(os.Args) > 1 { num, err := strconv.ParseInt(os.Args[1], 10, 64) if err != nil { panic(err) } var x...

Here's another one: ```go const multiple = 4 need := uint8(multiple - (len(digest) % multiple)) ```

The Go assert package calls this assertion [inDelta](https://pkg.go.dev/github.com/stretchr/[email protected]/assert#InDelta).

A few thoughts: * Does the catalog need a way to specify the default version of an extension when it has multiple versions? This would hand the case where the...