Javier Contreras

Results 6 comments of Javier Contreras
trafficstars

hey @sigmundpetersen I want to take over this one to warm up. WDYTH?

hey @sigmundpetersen , as I started digging into this issue, I got a few questions: 1. I see there is a taxonomy model, related [1-n with taxons models](https://github.com/openfoodfoundation/openfoodnetwork/blob/master/db/schema.rb#L887). I see...

It does @mkllnk , starting my engines then :rocket: .. Thanks tons!

I found this long time ago. From the dependency inversion point of view, it was kind of okayish to me to keep the instance variables as we pass an 'instance'...

Oh, I just noticed that I was miswriting the 'block' dependency. [The Readme states that we should instantiate the object from within the block.](https://github.com/rubiconmd/injectable/blame/master/README.md#L245). So I can confirm that doing...

Yup, deffo!, I would also add: when the memoized value(single value) depend on those arguments. Also I think memoization of single values takes a bigger transcendence when it comes to...