Andrew Tatomyr
Andrew Tatomyr
Actually, I think I've fixed that here: https://github.com/Redocly/redocly-cli/pull/1694/files#diff-a1ba985b0b0ab2998bb2679b71cce4267f2103867106142cc73b5c263fd3ab9f Please see the updated decorator. I encourage you to try the new decorator via a custom plugin instead of the existing one....
Thank you for the feedback @rubypersona! > I think it's supposed to say for (const mapping of Object.keys(parent.discriminator.mapping)) Essentially this is an equivalent to `in` in that case. > parent.discriminator.mapping[mapping]...
> However, we noticed that there are now some unexpected additions to our bundled OpenAPI spec. This what I was afraid of 😅. Let's try a couple of things here....
> For the new implementation, could you clarify where the function definitions should be imported from Same as in the original decorator: https://github.com/Redocly/redocly-cli/pull/1694/files#diff-a1ba985b0b0ab2998bb2679b71cce4267f2103867106142cc73b5c263fd3ab9fR1 You should be able to import them...
I confirm this is a bug. Thanks for reporting it!
@LukeHagar do you mind adding a simple e2e test for the case? (The corresponding folder is [\_\_tests\_\_/split](https://github.com/Redocly/redocly-cli/tree/main/__tests__/split)).
> I couldn't get any of the tests to run locally due to a warning about an outdated dep messing with the snapshot output It's most likely because you're using...
Could you rebase your branch as I believe smoke tests are failing due to the outdated code?
@LukeHagar it looks like it's too much to rebase. As for me, it'd be simpler to reapply your changes from scratch.
Any updates @LukeHagar 🙂?