Thomas Kluyver

Results 945 comments of Thomas Kluyver
trafficstars

I've had a go at this in #337.

@jhgoebbert could that error be related to connecting a websocket? Sadly, this branch doesn't support websockets yet. I think it would need either a change in Tornado (https://github.com/tornadoweb/tornado/pull/3172 ), or...

Just to mention, I am still interested in pushing this forwards, if anyone more involved with JSP thinks it's worthwhile. The biggest open question I see is what to do...

Ah, sorry, I missed your replies at the time. My tornado PR has now been merged (though it has yet to be released), so for now I've updated this PR...

Thanks! Then :crossed_fingers: this should be ready to try out. The combination of a websocket connection and a Unix socket backend will need Tornado 6.3, but websockets+TCP and regular HTTP...

The CI builds failed almost immediately with "E: Unable to locate package chefdk". I don't think that's anything related to the changes here.

Same again. I'm guessing something external to this repository has changed recently. Probably these messages are relevant: ``` Adding APT Sources 'sourceline' key missing: \{:name\=\>"chef-stable-trusty"\} ```

Oh, it looks like PR #1051 has a fix for it: https://github.com/travis-ci/travis-cookbooks/pull/1051/commits/a561e613f5372a953beda8c5fa73c3e6140ba159

The fix/workaround from #1051 seems to have made the CI pass. I'm inclined to leave switching the distro it checks on for someone else to do, because I don't know...

> Given that Python 3.6 is now the default Python on Travis CI ... I wasn't aware of that. Do you mean that a `language: python` build with no version...