Sergey Alexandrov

Results 92 comments of Sergey Alexandrov
trafficstars

Fixed is the master branch.

@matchai @davidkna This PR addresses a long-standing bug in one of the essential modules in a backward-compatible way. It comes with comprehensive test coverage and documentation updates--a solid contribution. Could...

In-memory PCD serialization/deserialization was contributed last year: #1986. You may take this as an example and implement the same for PLY format.

LGTM. Can't comment on the point type use cases, never used this class in my projects. I think testing with XYZ points is enough, this verifies that the algorithm is...

My colleague (Thomas, actually) has recently enquired about the status of this PR. Has anything changed from your side in the last... two years? Maybe rebase, check CI results, and...

I wonder why don't we apply this same specialization trick directly to `KdTree::nearestKSearchT()` function?

> No doubt that it would make more sense. On C++14 migration it will require a cleanup. Don't understand. Do you mean we can not implement it now? > Anything...

I don't know how comfortable you are with template stuff, so here is a quick snippet: ```cpp template inline int ``` This is the template line for the version where...

Sorry, I should have been more explicit. There is no need for helper classes. All we need is to replace ```cpp template inline int nearestKSearchT (const PointTDiff &point, int k,...