Peter Gorniak

Results 62 comments of Peter Gorniak

I added a step in CI to run the tests after compiling the package, so it'll fail if it can't generate. See for example https://github.com/sumpfork/dominiontabs/actions/runs/4333919353/jobs/7567436787#step:7:749 for the failing check above.

Hmm, yeah, I'm not sure we have anything like that right now as we use the list of cards actually being printed to generate the expansion dividers. Which maybe doesn't...

To note, the German changes all look fine to me - they're either switching to more common spellings, translating in the first place ("Scheu") or switching to use the female...

> @sumpfork As I read the code, I think we can remove the whole concept of "bonus text", with translations into multiple languages, and instead use the bold/italicized formatting downloaded...

I haven't looked in detail, but I'm very happy to replace the current language used to encode things like inline images - it grew organically out of a single initial...

I simplified the example (I was wrong before, this also doesn't work outside of constructors).

As another note, this does work if you access the L1 construct to add the second tag directly: ``` cfn_nested_stack = stack2.node.default_child cfn_nested_stack.tags.set_tag( "foo", "baz", priority=300 ) ```

hmm, I thought I fixed this recently, but I guess not - this is from the online generator?