dominiontabs
dominiontabs copied to clipboard
Update non-english language files with data from the wiki
These updates to the card_db_src files in non-English languages were done programatically by a script which scrapes the dominion strategy wiki, and extracts values from the tables.
I'm putting them here in a separate PR for ease of reviewing separately. Because this is a huge change, I've used a tool called dyff to compare the before/after as JSON objects. For the most part, this is merely adding data that was not already here, but there are a few changes.
I went through most of the changes, and made an attempt to adjudicate which version was better, and updated the wiki where the version from here seemed to be a better fit. I found and fixed several clear mistakes in the wiki, then reran the script to download and parse, resulting in the second commit.
Other than additions, here are the changes by language: The change list in Dutch is incomplete; I'll come back and finish it later. One change in Dutch that I'd appreciate the opinion of an actual Dutch-speaker on is capitalization. There were several cases where this code capitalized the last word of the name, and the wiki didn't. Which is right?
I deliberately didn't update the gzip'd versions of these files, because this won't be ready to merge until the code that can parse the wiki markup is in.
Czech:
Stash.name
± value change
- Stash
+ Tajná skrýš
Throne Room.name
± value change
- Trůní sál
+ Trůnní sál
Spy.name
± value change
- Špión
+ Špion
Bandit Camp.name
± whitespace only change
- Tábor·banditů· + Tábor·banditů
French:
Cutpurse.name
± value change
- Coupeur de bourses
+ Coupeur de bourse
Spanish:
No changes, only additions
Italian:
+ one map entry added:
Farm:
│ name: Harem
Conspirator.name
± value change
- Cospiratore
+ Cospiratori
Followers.name
± value change
- Seguaci
+ Sostenitori
German:
Nobles.name
± value change
- Adelige
+ Adlige
Peddler.name
± value change
- Hausierer
+ Hausiererin
Road Network.name
± value change
- Strassennetz
+ Straßennetz
Shy.name
± value change
- Shy
+ Scheu
Trader.name
± value change
- Fahrender Händler
+ Fahrende Händlerin
Warrior.name
± value change
- Krieger
+ Kriegerin
Way of the Mole.name
± value change
- Weg des Maulwurfs
+ Weg des Maulwurfes
Dutch:
Bad Omens.name
± value change
- Slechte Voortekenen
+ Slechte voortekenen
Bag of Gold.name
± value change
- Zak met Goud
+ Zak met goud
Basilica: TODO: update the code with the latest from the wiki
Black Market.name
± value change
- Black Market
+ Zwarte markt
Cabin Boy.name
± value change
- Scheepjesjongen
+ Scheepsjongen
Livery.name ± value change - Stalhouderij + Paardenhouderij
Soldier.name ± value change - Landknecht + Landsknecht
Oops, looks like my script put the card text in "text", not "description". I'll fix that.
@sumpfork As I read the code, I think we can remove the whole concept of "bonus text", with translations into multiple languages, and instead use the bold/italicized formatting downloaded from the wiki, in each language. Does that sound good to you?
To note, the German changes all look fine to me - they're either switching to more common spellings, translating in the first place ("Scheu") or switching to use the female form of a job.
@sumpfork As I read the code, I think we can remove the whole concept of "bonus text", with translations into multiple languages, and instead use the bold/italicized formatting downloaded from the wiki, in each language. Does that sound good to you?
I'll have to remember what that even is :). But probably, if it sounds good to you.