stuartmorgan-g

Results 1230 comments of stuartmorgan-g

Sorry for the reviewer spam; since this touches most packages it brings in almost all of the CODEOWNERs. Feel free to ignore this unless you are @tarrinneal or @bparrishMines (in...

I'm overriding the version check here even though policy would normally be to release it due to the code changes; since the changes are a) automated, b) small, and c)...

> There's a few packages where only the CHANGELOG.md seems to have been updated, but not the pubspec.yaml or any other file within them? Good eyes! I must have messed...

Oh, I see; this has bit me before, but I forgot: `--run-on-changed-packages` doesn't actually do what I want here because I changed the script, which forces all packages to be...

You scored 100% by the way; re-running it with the right targeting touched 14 fewer packages.

Hm, it's failing the maps renderer selection test almost all of the time. I wonder if there's some server-side issue here where we're getting the legacy mode regardless of the...

Since the failure here was one of the random ARM macOS timeouts, and the same shard passed on the previous run, I'm just going to land this now before this...

It may be useful to compare with a PR like https://github.com/flutter/plugins/pull/4200 that set up initial integration tests for some of our other plugins. It's getting to be a while ago...

> This means that unlike in the linked pr we cant verify the existence of a plugin. That's fine, it can be entirely a no-op. > It is possible that...