stuartmorgan-g

Results 1190 comments of stuartmorgan-g

@blasten Could this be related to the Android platform view changes?

I don't think it's a different issue; the workaround that landed in the maps plugin could definitely have the behavior described there.

Based on further discussion, I think we'll update maps so that its Hybrid Composition switch works again post-3.0, and then default it to Hybrid Composition, and then explore options for...

> It not only affects google map but also other plugin. Please file other issues for other plugins; we'll need to follow up on each one separately to find out...

Re-opening; defaulting to HC avoids this in the default case, but we want to fix this for TLHC so that we can switch back.

Yes, that's essentially https://github.com/flutter/flutter/issues/103686#issuecomment-1169163526

> Testing: This adds no new functionality The criteria for testing is not that we only test new functionality, it's https://github.com/flutter/flutter/wiki/Tree-hygiene#tests > and thus should be covered in tests. The...

> We should maybe consider running tests against a debug version of the engine. Do the engine builders publish those artifacts?

> Right, the point is that the code in this PR has test coverage. I'm not sure why you are asserting things that aren't in dispute and aren't related to...

(Mostly small comments; There are some big walls of text so I was skimming in the generator, but it looks like the overall structure here is pretty well factored.)