Luca Giannini

Results 7 comments of Luca Giannini
trafficstars

> Currently having the same issue

> I'm not super familiar with rootless docker setups, but if XPipe would respect the `DOCKER_SOCKET` variable, this issue would be fixed? The convention from the [docker manual](https://docs.docker.com/engine/security/rootless/#install) is to...

Last message just means what you would pass to SendMessag. currently if you have a history with all messages already, or would want to replay a history. You need to...

Do need some help as to why [this](https://github.com/LGXerxes/meilisearch-python/blob/lgx/requests-session/tests/errors/test_timeout_error_meilisearch.py#L11-L18) test doesn't pass: ``` ==================================================================== short test summary info ===================================================================== FAILED tests/errors/test_timeout_error_meilisearch.py::test_client_timeout_error - Failed: DID NOT RAISE =========================================================== 1 failed, 243 passed,...

> > Do need some help as to why [this](https://github.com/LGXerxes/meilisearch-python/blob/lgx/requests-session/tests/errors/test_timeout_error_meilisearch.py#L11-L18) test doesn't pass: > > It fails because the test patches `requests.get`, but you changed the code to use `session.get`...

Currently trying to apply your changes, but not passing around the HttpRequests also affects how tasks are created. As each task also creates a HttpReqeusts object. https://github.com/LGXerxes/meilisearch-python/blob/lgx/requests-session/meilisearch/task.py#L14-L29 Perhaps it is...

@sanders41 I think the singleton pattern is probably the best choice here. Don't see any issues with this implementation.