Jack Grigg

Results 896 comments of Jack Grigg
trafficstars

#621 has been altered to fix the bug referenced in the OP. So this issue is now just about whether we want to keep this API at all.

> What I have problem with is that `z_getbalanceforviewingkey` does a different thing than `z_getbalance`. With `z_getbalance` I have a simple API which lets me know what is an outstanding...

> tests & Clippy lints appear to be failing. That's expected; this PR requires a newer Rust than our MSRV, due to required dependencies. We can merge this when we...

This is now based on #691 and uses `tonic`.

Clippy lints fixed in https://github.com/zcash/librustzcash/pull/691/commits/587e1fa60b4d408cfb3762fced23e8b620a71532.

Yep. There are two necessary steps here: - Change all parallelisation imports to import from `halo2_proofs::multicore` (so we have a single place to control everything). - I'm fixing this as...

We believe this is fixed by #6054, which will be in release 5.1.0. If the issue persists after then, please re-open this issue.

We may want to have different kinds of IVC and PCD, and so it would be ideal if these proof structures encoded the kind of IVC or PCD in their...

This issue is being narrowed in scope to focus specifically on the IVC cycle. Hopefully we can reuse some or all of this for PCD, but we can figure that...

#6172 makes significant reductions to memory consumption of wallet scanning. It shouldn't in theory affect this issue because no shielded addresses had been created for this wallet, but it would...