Jack Grigg

Results 899 comments of Jack Grigg

@ebfull and I discussed this in a pairing. Initially we were reluctant to accept this PR, because the intent of storing the parameters was to ensure they stayed self-consistent across...

Summary of reviews: PR | @daira | Player 2 | Will include --- | --- | --- | --- bitcoin/bitcoin#7129 | | | bitcoin/bitcoin#7133 | | | bitcoin/bitcoin#7482 | |...

Aside from general fixes, there are several features here: - ~BIP 111: `NODE_BLOOM` service bit~ - ~Relay blocks when pruning~ - ~`-maxuploadtarget` option~ - ~`-blocksonly` option~ - BIP 130: direct...

There are only a few 0.12 P2P/Net PRs that I have not included in here: - bitcoin/bitcoin#7179 - depends on bitcoin/bitcoin#5913 - bitcoin/bitcoin#7181 - depends on some mempool changes -...

Rebased on master to fix merge conflict.

Dropping from 1.0.14 due to lack of review.

I'm going to try and extract these into separate PRs to make them easier to review (dependent on merge conflicts).

I have extracted the following PRs: - ~#2812 (store banlist)~ merged! - ~#2813 (uacomment config parameter)~ merged! - ~#2814 (BIP 111: `NODE_BLOOM` service bit)~ merged! - ~#2815 (Relay blocks when...

Status: I need to re-backport #2812 and #2816 (since they now conflict), and then rebase this PR after those two are merged (and/or dropped).

Rebased on master after #2812 merged, to remove the commits it contained. I will rebase again after #2816 lands, and then extract out the next tranche of commits.