Christophe Coevoet

Results 2519 comments of Christophe Coevoet

To go even further, it would be nice after that to make MethodProphecy generic based on the expected return type to detect bad configuration of `willReturn`, but this might be...

@WedgeSama I would suggest you to create a custom constraint in your project for that case (or in a third-party bundle if you want to reuse it). I don't think...

The usage of the constants to define the array would bump the requirement on `doctrine/collections`. Couldn't you use the value of the constant instead (eventually putting a comment with the...

another thing which is necessary (but probably as a separate PR) is fixing the SQL conversion of the CONTAINS operator (it needs to escape the placeholders in the value)

My first suggestion is to write the code this way: ``` php 'LIKE' => 'LIKE %s', // Comparison::LIKE 'NOTLIKE' => 'NOT LIKE %s', // Comparison::NOT_LIKE ``` This way, it will...

Maybe the description of the option should be improved so that `behat --help` explains this relation between both options

There is strictly no guarantee in the ContainerInterface that a service class is a subtype of the object id, even when the object id is a class-string. This PR adds...

> Indeed, but I thought it would be okay since it's only PHPDoc. Our phpdoc in our interfaces is considered as part of the defined contract (it is taken into...