Christophe Coevoet
Christophe Coevoet
Accepting `null` in the polyfill should indeed be the right behavior (as done in other polyfills), to match the behavior of the native function. This is what we do for...
Just replacing `substr` with `mb_substr` would break things entirely (even for cases where the current logic is lucky enough to avoid breaking UTF-8 codepoints). `mb_substr` expects an offset computed in...
I think we should deprecate this `bin/phpunit` in favor of using `vendor/bin/phpunit` directly, which is the native way of using phpunit when installed with Composer (and will also work on...
@fabpot what is the state of this PR ? Do you plan to fix it or to abandon it ?
@alademann any chance you update your PR with the requested changes ?
`$this->get()` does not make sense for a static method IMO, as there is no `$this`
An alternative is to add a step running `npm ci` before the step using `cloudflare/wrangler-action`, to install the npm dependencies of the project. In such case, `cloudflare/wrangler-action` will use the...
Should those deprecations wait for the removal of dynamic Sass imports or should the deprecation happen separately ? We already distinguish dynamic (Sass) imports and static (CSS) imports at parse...
> > Btw, the case of multiple imports for a single `@import` should probably trigger an error when parsing the CSS syntax instead of parsing one of the Sass syntaxes,...
@eschwartz For the images or the CSS imports, it could work. For the less imports, it would be a huge pain as it would require running the filter before less...