Steven Johnson
Steven Johnson
Is this ready to land (pending review comments)?
> This is ready on my end. @steven-johnson -- we should coordinate adding testing to the buildbots. Should we wait to land this until we have that? yes, probably
Hmm, it works perfectly on my Mac using Chrome using today's EMCC and the wasm experimental features enabled in Chrome. What specific cmake configure command did you use? I did...
> This can be observed by running cmake --build build --target wasm. What's with the `--target wasm` part? I don't see any target of that name.
FYI, I have `Experimental JavaScript shared memory features` set to `default`
(I built with today's EMCC, btw... maybe there was a temporary buggy version?)
FWIW, enabling GRADIENT_DESCENT for the Python apps in this way seems to take ~forever to compile -- investigating EDIT: building in verbose mode reveals `Warning: Autoscheduling is not enabled in...
> The option is GRADIENT_DESCENT, no _OPT suffix Why didn't this produce an error at CMake configure time? Surely unknown keywords should fail.
> According to GCC docs, we should use `__fp16` instead of `_Float16` on ARM (source https://gcc.gnu.org/onlinedocs/gcc/Half-Precision.html). This link also says: **It is recommended that portable code use the _Float16 type...
Ugh, what a nightmare -- we went from having no compiler support for float16 to confusing-and-too-many-options support. (Does Clang-for-Arm report similar errors?) I'm also genuinely puzzled here -- surely you...