Steven Johnson comments

Results 456 comments of


                                            Steven Johnson

Device runtime "wrap native" routines should check for invalid device buffers and return an error

> What's the proper way to report the error back to the caller? > > * return an error code and leave it up to the caller? > * call...

JITModule: rework/fix `__udivdi3` handling

Is this still an active PR?

Memory leak in local laplacian filter Manual scheduling

> Should the PyHalideBuffer destructor be calling device_free? If we do that, don't we risk freeing a device allocation that might be in use by a shared buffer allocation (e.g....

Memory leak in local laplacian filter Manual scheduling

OK, I will take a look

Memory leak in local laplacian filter Manual scheduling

OK, yeah, I think an explicit call to `halide_device_free()` is likely needed in the dtor to `PyHalideBuffer`, let me do some testing first

Memory leak in local laplacian filter Manual scheduling

I think https://github.com/halide/Halide/pull/8439 is what we need, please give it a try

Fast atan and atan2 functions.

> Oh dear... I don't even know what WebGPU is... @steven-johnson Is this supposed to be an actual platform that is fast, and where performance metrics make sense? I can...

Fast atan and atan2 functions.

> @steven-johnson The build just broke on something LLVM related it seems... There seems to be no related commit to Halide. Does LLVM constantly update with every build? We rebuild...

Fast atan and atan2 functions.

Ping to @abadams or @zvookin for review

Fast atan and atan2 functions.

Looks like this is ready for final review... ?